Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY
From: James Morris <jmorris@namei.org>
Date: 2006-07-13 01:53:00
Also in:
selinux
On Wed, 12 Jul 2006, Venkat Yekkirala wrote:
+static inline void security_xfrm_skb_secid(struct sk_buff *skb, u32 *secid)
{
- return security_ops->xfrm_decode_session(skb, fl);
+ BUG_ON(security_ops->xfrm_decode_session(skb, secid, 0));BUG_ON looks wrong here, in that you don't know why the LSM returned an error, and why should the box panic at this point at all? -- James Morris [off-list ref]