Thread (7 messages) 7 messages, 4 authors, 2006-06-30

Re: [PATCH 2.6.17] support for TSO over IPv6

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2006-06-30 00:39:55

On Fri, Jun 30, 2006 at 09:32:44AM +1000, Herbert Xu wrote:
quoted
diff -upNr netdev.org/include/linux/skbuff.h netdev.ipv6_tso/include/linux/skbuff.h
--- netdev.org/include/linux/skbuff.h   2006-06-27 07:30:36.000000000 -0700
+++ netdev.ipv6_tso/include/linux/skbuff.h      2006-06-27 07:38:48.000000000 -0700
@@ -170,8 +170,9 @@ enum {
};

enum {
-       SKB_GSO_TCPV4 = 1 << 0,
-       SKB_GSO_UDPV4 = 1 << 1,
+       SKB_GSO_TCP = 1 << 0,
+       SKB_GSO_UDP = 1 << 1,
+       SKB_GSO_TCPV6 = 1 << 2,
};
BTW, you should rediff against Dave's current tree which has a few
extra bits there.

You should also leave TCPV4 as is and just add the TCPV6 bit.
BTW, does your card handle ECN correctly? If not then we should change
the new ECN bit to apply to both TCPv4 and TCPv6 since

1) We now have a piece of hardware that handles TSO6 and it doesn't do ECN.
2) It's quite likely that if the NIC can handle ECN in TCPv4 then it can do
   it in TCPv6.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help