Re: [PATCH]NET: Add ECN support for TSO
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2006-06-28 04:42:20
On Tue, Jun 27, 2006 at 09:37:01PM -0700, Michael Chan wrote:
Signed-off-by: Michael Chan <mchan@broadcom.com>
Looks good to me too!
quoted hunk ↗ jump to hunk
@@ -56,6 +55,9 @@ static inline void TCP_ECN_send(struct s if (tp->ecn_flags&TCP_ECN_QUEUE_CWR) { tp->ecn_flags &= ~TCP_ECN_QUEUE_CWR; skb->h.th->cwr = 1; + if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4) + skb_shinfo(skb)->gso_type |= + SKB_GSO_TCPV4_ECN;
As a byte-pincher I must suggest that you turn this check into something like if (skb_shinfo(skb)->gso_type) or even if (skb_shinfo(skb)->gso_size) :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt