Re: [PATCH 20/32] rt2x00: byte ordering correctness
From: Ivo van Doorn <hidden>
Date: 2006-04-28 12:58:20
Attachments
- (unnamed) [application/pgp-signature] 189 bytes
From: Ivo van Doorn <hidden>
Date: 2006-04-28 12:58:20
On Friday 28 April 2006 00:13, Christoph Hellwig wrote:
On Fri, Apr 28, 2006 at 12:03:12AM +0200, Ivo van Doorn wrote:quoted
From: Ivo van Doorn <redacted> Fix various little/big endian conversions. rt2500pci should use cpu_to_le32 and rt2500usb should not.While you're at it can you add __be* annotations to the hardware datastructures so the endianess handling can be verified using sparse?
I am not sure if that would be a wise idea, there is no byte ordering done in rt2500usb except for the EEPROM contents which is little endian. So when the module is used on a normal x86 platform, there won't be any big endian structures or fields.