----- Original Message ----- 
From: "Patrick McHardy" <redacted>
To: "Adrian Bunk" <redacted>
Cc: <redacted>; <redacted>; 
[off-list ref]; "Jing Min Zhao" 
[off-list ref]; [off-list ref]
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper

[The hotmail address of the author doesn't work, CCed sourceforge-address]

Adrian Bunk wrote:

quoted

Two comments on the H.323 conntrack/NAT helper:
- the function prototypes in ip_nat_helper_h323.c are _ugly_,
  please move them to a header file

Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.

quoted

- is there a reason for not using EXPORT_SYMBOL_GPL?

I would prefer that too.

Sure, I'll do that.

Thanks

Jing Min Zhao