Thread (2 messages) 2 messages, 2 authors, 2006-03-17

Re: [git patches] net driver fixes

From: Linus Torvalds <torvalds@osdl.org>
Date: 2006-03-17 00:42:46
Also in: lkml


On Thu, 16 Mar 2006, Jeff Garzik wrote:
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
The commit comments for the Chelsio driver fix are a bit unfortunate.

The array clearly _does_ have three elements, it's just that the code used 
to access the fourth (that didn't exist), and now it accesses the third.

So when the commit says "The array should contain 2 elements" it's just 
being really confused.

Of course, using an array index of "cmdQ_restarted[2]" without any 
explanation for why it's index 2, the bug was inevitable. Maybe a symbolic 
value for the magic array indices?

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help