Re: [2.6 patch] hostap_{pci,plx}.c: fix memory leaks

Adrian Bunk [off-list ref] wrote:

+       if (pci_enable_device(pdev))
+               return -EIO;
+
       hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL);
       if (hw_priv == NULL)
               return -ENOMEM;
       memset(hw_priv, 0, sizeof(*hw_priv));

-       if (pci_enable_device(pdev))
-               return -EIO;
-

You've just turned it into a leak of a different kind.

Why not jump to the error exit instead?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt