Thread (21 messages) 21 messages, 5 authors, 2006-03-30

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

From: Andrew Morton <hidden>
Date: 2006-03-11 09:43:15
Also in: lkml

Chris Leech [off-list ref] wrote:
Locks down user pages and sets up for DMA in tcp_recvmsg, then calls
 dma_async_try_early_copy in tcp_v4_do_rcv
All those ifdefs are still there.  They really do put a maintenance burden
on, of all places, net/ipv4/tcp.c.  Please find a way of abstracting out
the conceptual additions which IOAT makes to TCP and to wrap that into
inline functions, etc.  See how tidily NF_HOOK() has inserted things into
the net stack.

Also, for something which is billed as an performance enhancement,
benchmark numbers are the key thing which we need to judge the desirability
of these changes.  What is the plan there?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help