Re: [PATCH] [NETFILTER] nf_conntrack: clean up to reduce size of 'struct nf_conn'
From: Yasuyuki KOZAKAI <hidden>
Date: 2006-02-13 01:32:49
Also in:
netfilter-devel
From: Yasuyuki KOZAKAI <hidden>
Date: 2006-02-13 01:32:49
Also in:
netfilter-devel
Hi, Harald, From: Harald Welte <laforge@gnumonks.org> Date: Sun, 12 Feb 2006 18:56:22 +0100
[NETFILTER] nf_conntrack: clean up to reduce size of 'struct nf_conn' This patch moves all helper related data fields of 'struct nf_conn' into a separate structure 'struct nf_conn_help'. This new structure is only present in conntrack entries for which we actually have a helper loaded. Also, this patch cleans up the nf_conntrack 'features' mechanism to resemble what the original idea was: Just glue the feature-specific data structures at the end of 'struct nf_conn', and explicitly re-calculate the pointer to it when needed rather than keeping pointers around. Saves 20 bytes per conntrack on my x86_64 box. A non-helped conntrack is 276 bytes. We still need to save another 20 bytes in order to fit into to target of 256bytes. Signed-off-by: Harald Welte <redacted>
This patch seems not to include fixes I pointed out and you said "fixed". Please confirm if you really sent the intended one. Regards, -- Yasuyuki Kozakai