Re: RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction
From: Grant Grundler <hidden>
Date: 2006-01-18 18:02:41
Also in:
lkml
From: Grant Grundler <hidden>
Date: 2006-01-18 18:02:41
Also in:
lkml
On Wed, Jan 18, 2006 at 09:46:03AM -0800, Sean Hefty wrote:
Grant Grundler wrote:quoted
quoted
+static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask)
...
quoted
Is this code going to get invoked very often?In practice, it would be invoked when matching any listen requests originating from the CMA (RDMA connection abstraction).
hrm..I'm not sure how to translate your answer into a workload. e.g. which netperf or netpipe test would excercise this alot? Or would it take something like MPI or specweb/ttcp?
quoted
If so, can the mask operation use a "native" size since IB_CM_PRIVATE_DATA_COMPARE_SIZE is hard coded to 64 byte? e.g something like: for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE/sizeof(unsigned long); i++) ((unsigned long *)dst)[i] = ((unsigned long *)src)[i] & ((unsigned long *)mask)[i];Yes - something like this should work. Thanks.
Do you need a patch? I can submit one but it will be untested. thanks, grant