Thread (5 messages) flat view 5 messages, 3 authors, 2006-01-11

Re: [PATCH] net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

From: Arnaldo Carvalho de Melo <hidden>
Date: 2006-01-09 11:31:11
Also in: lkml

On 1/9/06, Arnd Bergmann [off-list ref] wrote:
On Monday 09 January 2006 06:46, Shaun Pereira wrote:
quoted
Since we are interested in ioctl's from userspace I have not added the
.compat_ioctl function pointer to struct net_device. The assumption
being once the userspace data has reached the kernel via the socket api,
if the socket layer protocol knows how to handle the data, it will
prepare it for the device.
I think we need to have it in the long run, but if you don't need it
for x25, then it's not your call to implement net_device->compat_ioctl.
I've been thinking about how to get it right before, but did not
reach a proper conclusion, since dev_ioctl is called in so many places
that would all need to be changed for this.
Nowadays dev_ioctl is only called from one funcion: sock_ioctl in
net/socket.c, this is after a recent changeset by hch.

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help