Thread (1 message) 1 message, 1 author, 2006-01-04

Re: [PATCH] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2006-01-04 23:56:57
Also in: lkml

Zhu Yi [off-list ref] :
This patch fixes the warning below warning for the ipw2200 driver.

  NETDEV_TX_BUSY returned; driver should report queue full via
  ieee_device->is_queue_full.
Beyond what was said by Stephen Hemminger, the driver reports a
NETDEV_TX_BUSY when !STATUS_ASSOCIATED: neither this patch nor mine
fix it. 

Btw the patch that I posted earlier forgets to protect against 
every undue wake-up through:

ipw_rx
-> ipw_rx_notification
   -> priv->link_up (work_queue)
      -> ipw_bg_link_up
         -> ipw_link_up

It will need some extra care to correctly play the
netif_{stop/wake}_queue dance.

--
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help