Re: [PATCH] [NETFILTER] nfnetlink_log: add sequence numbers for log events
From: Patrick McHardy <hidden>
Date: 2006-01-30 23:32:21
Also in:
netfilter-devel
From: Patrick McHardy <hidden>
Date: 2006-01-30 23:32:21
Also in:
netfilter-devel
Harald Welte wrote:
Hi Dave, please apply, thanks! [NETFILTER] nfnetlink_log: add sequence numbers for log events By using a sequence number for every logged netfilter event, we can determine from userspace whether logging information was lots somewhere downstream.
BTW, I have a patch I wanted to submit on top of this, which changes the *LOG targets to do "reliable" logging, which means if we encounter any errors during logging (for example from netlink), the packet will be dropped. This makes as sure as possible that no connections will be silently accepted. Its a slight change of user-visible behaviour, but since it only affects corner-cases I think it should be OK. I could add some flags to retain the current behaviour, but I think its not worth it. For ULOG its only possible to do this without queueing, so if qthreshold > 1 we will keep the old behaviour, LOG can't fail anyway. Any objections?