Thread (2 messages) 2 messages, 2 authors, 2005-12-22

[KJ] Re: [PATCH] Deinitialise static variables in net/core/pktgen.c

From: "David S. Miller" <davem@davemloft.net>
Date: 2005-12-22 20:52:32

From: "Jaco Kroon" <redacted>
Date: Tue, 20 Dec 2005 09:59:23 +0200 (SAST)
static variables should not be explicitly initialised to 0.  This causes
them to be placed in .data instead of .bss.  This patch de-initialises 3
static variables in net/core/pktgen.c.

There are approximately 800 more such variables in the source tree
(2.6.15rc5).  If there is more interrest I'd be willing to track down the
rest of these as well and de-initialise them as well.
Applied, _but_:

1) Please provide a "Signed-off-by: " line next time.
2) Please send the patches in such a way that your email
   client doesn't corrupt that patch, there were newlines
   added etc.

Thanks.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help