Re: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)
From: YOSHIFUJI Hideaki / 吉藤英明 <hidden>
Date: 2005-11-15 01:22:14
Also in:
lkml
In article [ref] (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng [off-list ref] says:
The "score.rule++" doesn't make any sense for me. According to codes above, I think it should be "hiscore.rule++;" .
Oops, you're right.
Signed-off-by: Yan Zheng<redacted>
Acked-by: YOSHIFUJI Hideaki <redacted>
/* Rule 8: Use longest matching prefix */
- if (hiscore.rule < 8)
+ if (hiscore.rule < 8) {
hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr);
- score.rule++;
+ hiscore.rule++;
+ }
score.matchlen = ipv6_addr_diff(&ifa->addr, daddr);
if (score.matchlen > hiscore.matchlen) {
score.rule = 8;-- YOSHIFUJI Hideaki @ USAGI Project [off-list ref] GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA