Re: [0/3] Fix timer bugs in neighbour cache

From
Arnaldo Carvalho de Melo <hidden>
Date
2005-10-23 16:16:34
Also in
lkml
Reply to
Herbert Xu, 2005-10-23
Em Sun, Oct 23, 2005 at 05:30:21PM +1000, Herbert Xu escreveu:
Reuben Farrelly [off-list ref] wrote:
quoted
Oct 17 18:49:40 tornado kernel: NEIGH: BUG, double timer add, state is 1
Oct 17 18:51:04 tornado last message repeated 3 times
Oct 17 18:52:05 tornado last message repeated 5 times
Oct 17 18:52:11 tornado last message repeated 2 times
Excellent.  Looks like we actually caught something.  Pity we don't have
a stack trace which means that there might be more bugs.

Anyway, here are three patches which should fix this.  This should go
into 2.6.14.

Arnaldo, you can pull them from

master.kernel.org:/pub/scm/linux/kernel/git/herbert/net-2.6.git
Thanks, pulled.

I guess at some point I'll try to make the neighbour code more like the
sock one where we have things like sk_reset_timer and sk_stop_timer for
this purpose.

- Arnaldo
Thread (7 messages) 7 messages, 4 authors, 2005-10-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help