Re: [patch 2.6.14-rc3 2/3] sundance: probe PHYs from MII address 0
From: John W. Linville <hidden>
Date: 2005-10-19 12:00:47
Also in:
lkml
On Tue, Oct 18, 2005 at 10:31:51PM -0400, Jeff Garzik wrote:
John W. Linville wrote:
quoted
--- a/drivers/net/sundance.c +++ b/drivers/net/sundance.c@@ -608,7 +608,7 @@ static int __devinit sundance_probe1 (stnp->phys[0] = 1; /* Default setting */ np->mii_preamble_required++; - for (phy = 1; phy < 32 && phy_idx < MII_CNT; phy++) { + for (phy = 0; phy < 32 && phy_idx < MII_CNT; phy++) {NAK. MII address 0 should be scanned _last_, after all other addresses. In some phys, it is a ghost, mirroring another address. Take a look at some of the original Becker MII scan code from ftp://ftp.scyld.com/pub/network/ to see an elegant method for this.
Hmmm...that is clever...patch to follow... John -- John W. Linville linville@tuxdriver.com