Thread (7 messages) flat view 7 messages, 3 authors, 2005-09-14

Re: [patch 9/11] net: dst_entry.refcount, use, lastuse to use alloc_percpu

From: Rusty Russell <hidden>
Date: 2005-09-14 07:21:05
Also in: lkml

On Tue, 2005-09-13 at 16:27 -0700, David S. Miller wrote:
From: Ravikiran G Thirumalai <redacted>
Date: Tue, 13 Sep 2005 16:17:17 -0700
quoted
But even 1 Million dst cache entries would be 16+4 MB additional for
a 4 cpu box....is that too much?
Absolutely.

Per-cpu counters are great for things like single instance
statistics et al.  But once you start doing them per-object
that's out of control bloat as far as I'm concerned.
This is why my original per-cpu allocator patch was damn slow, and
GFP_KERNEL only.  I wasn't convinced that high-churn objects are a good
fit for spreading across cpus.

I thought that net devices and modules (which uses a primitive
hard-coded "bigref" currently) were a fair uses for bigrefs, though I'd
like to see some stats.

Cheers,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help