Re: [PATCH] 3c59x: read current link status from phy

On Thu, 2005-09-08 at 15:35, Bogdan Costescu wrote:

On Thu, 8 Sep 2005, Tommy Christensen wrote:

quoted

The idea is to avoid an extra delay of 60 seconds before detecting 
link-up.

But you are adding the read to a function that is called repeatedly to 
fix an event that happens only once at start-up !

Link state can change anytime, not just at start-up.  That's why
it's being repeatedly monitored ;-)

If this read is really needed (I still doubt it...), can't it be 
performed in vortex_up(), by possibly doubling the existing one there ?
vortex_up() is executed only once at start-up, not every 60 seconds.

That won't solve the reported issue, unfortunately.

Besides, how long would you like to wait for network connectivity
after plugging in the cable?  It is now lowered from [60-120] to
[0-60] seconds.

Personally, I'd prefer the delay to be < 10 seconds.


-Tommy