Re: [PATCH 8/8] orinoco: New driver - spectrum_cs.

On Tue, 2005-09-06 at 12:24 +0100, Christoph Hellwig wrote:

quoted

+#ifdef  __IN_PCMCIA_PACKAGE__
+#include <pcmcia/k_compat.h>
+#endif /* __IN_PCMCIA_PACKAGE__ */

this doesn't make sense for a 2.6 driver.

Fixed in my tree, thanks.  Patches will be sent shortly.

quoted

+#ifdef SPECTRUM_FW_INCLUDED
+/* Header with the firmware */
+#include "spectrum_fw.h"
+#else	/* !SPECTRUM_FW_INCLUDED */

While I see the point of this for the standalone orinoco driver package
it doesn't make sense for the version in the kernel tree.

Likewise.

quoted

+#define CS_CHECK(fn, ret) \
+  do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)

I don't think this macro abuse helps anyone..

Sure, but it's abused by many drivers.  Maybe next time.

-- 
Regards,
Pavel Roskin



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf