Re: [PATCH] Fix socket bitop damage
From: Thomas Graf <tgraf@suug.ch>
Date: 2005-08-22 11:14:36
Also in:
linux-hams
From: Thomas Graf <tgraf@suug.ch>
Date: 2005-08-22 11:14:36
Also in:
linux-hams
* Ralf Baechle [ref] 2005-08-22 12:02
The socket flag cleanups that went into 2.6.12-rc1 are basically oring the flags of an old socket into the socket just being created. Unfortunately that one was just initialized by sock_init_data(), so already has SOCK_ZAPPED set. As the result zapped sockets are created and all incoming connection will fail due to this bug which again was carefully replicated to at least AX.25, NET/ROM or ROSE.
I'm probably to one to blame here but I don't get the point yet. What I did was to change the bitfield based flags to use sk_flags like this: - sk->sk_zapped = osk->sk_zapped; + + if (sock_flag(osk, SOCK_ZAPPED)) + sock_set_flag(sk, SOCK_ZAPPED);