Re: [PATCH] fix dst_entry leak in icmp_push_reply()

Ollie Wild wrote:

That said, I appreciate that the if-else condition doesn't seem quite
right.  The problem is, the icmp_push_reply() routine is implicitly
using the queue as a success indicator.  I put the
ip_flush_pending_frames() call inside the else block because I wanted to
guarantee that one of ip_push_pending_frames() and
ip_flush_pending_frames() is always called.  Both will do proper cleanup.

I'm open to suggestions if you think there's a cleaner way to implement
this.

Checking the return value of ip_append_data seems cleaner to me.
Patch attached.

Signed-off-by: Patrick McHardy <redacted>