Re: [PATCH] add bridging support to nfnetlink_{log,queue}

Op ma, 08-08-2005 te 15:24 +0200, schreef Harald Welte:

quoted

There is one case missing: the brouter case. If br0=eth0+eth1 and a
packet arrives at eth0 (not br0) in the IP code (not the bridge code),
then the indev must be eth0, not br0.  How about something like this?

Ok, I've implemented your suggested modifications now.

There's still one small issue: if CONFIG_BRIDGE_NETFILTER isn't set in
the kernel configuration but ebtables is enabled, then the physindev
should still be filled in if ebt_ulog is used. I'm afraid this will
result in more ugly ifdef's.
I don't mind making CONFIG_BRIDGE_NETFILTER mandatory for people wanting
to log the logical {in,out}put device, if you feel it would uglify the
code too much otherwise... The {in,out}dev sent to userspace will then
be different depending on whether CONFIG_BRIDGE_NETFILTER is set or not.
People can still disable bridge-nf at runtime with the right /proc
entry. This should then be stated somewhere very clearly.

cheers,
Bart