Re: [hipl-users] Re: [PATCH 2.6.12.2] XFRM: BEET IPsec mode for Linux
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-07-30 11:15:00
Diego Beltrami [off-list ref] wrote:
The modifications in the ESP functions are due to the hybrid cases when Inner and Outer address families are different; in those cases the values returned by espX functions are not coherent.
I see. However, this is really a consequence of us not implementing interfamily transforms for plain old tunnel mode. Had we implemented that, it would be a piece of cake to extend this to BEET without touching ESP.
quoted
Also, if you're going to do cross-family transforms, it should be done for both BEET and plain tunnel-mode.Potentially it could be possible also for plain tunnel-mode: this will require further analysis.
It definitely does need further analysis even for BEET mode. The rcv path for interfamily transforms is straightforward since we pass through netif_rx. However, on the outbound path things aren't that simple. I suggest that you remove the interfamily support for the initial merge of the BEET implementation. We can then readd it for both plain tunnel and BEET mode. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt