Re: [PATCH 1/2] updates for [nf|ct]netlink and event API
From: Thomas Graf <tgraf@suug.ch>
Date: 2005-06-30 18:02:38
Also in:
netfilter-devel
From: Thomas Graf <tgraf@suug.ch>
Date: 2005-06-30 18:02:38
Also in:
netfilter-devel
* Patrick McHardy [ref] 2005-06-30 15:27
Thomas Graf wrote:quoted
Good point, after all, I think structs have been used too often and we now suffer from backwards compatbility issues. The points likely to be argueable are things like trim responsibility in the error handling, i.e. delegate it down to the function which also created the header or trim on every level. Other than that the whole thing should be pretty straight forward.I think for nested attributes error handling should happen on the outer level. Just trimming on the inner level would leave a half-finished nested attribute.
I can agree with this, the question that remains is: do we want to trim in functions where no nesting is done at all? i.e. things like the generic network statistics dumping interface.