Re: [patch 2.6.12-rc5] tg3: add bcm5752 entry to pci.ids
From: "Michael Chan" <mchan@broadcom.com>
Date: 2005-05-27 19:15:00
Also in:
lkml
On Fri, 2005-05-27 at 15:00 -0400, John W. Linville wrote:
On Fri, May 27, 2005 at 07:53:35PM +0100, Christoph Hellwig wrote:quoted
On Fri, May 27, 2005 at 02:47:52PM -0400, John W. Linville wrote:quoted
quoted
+ 1600 NetXtreme BCM5752 Gigabit Ethernet PCI ExpressI don't think you should mention "PCI Express" here. That can trivially befound it looking at the configuration header.I'm just following what is at pciids.sourceforge.net. Plus, it is already like that for nine other IDs: 1659 NetXtreme BCM5721 Gigabit Ethernet PCI Express 1677 NetXtreme BCM5751 Gigabit Ethernet PCI Express 167d NetXtreme BCM5751M Gigabit Ethernet PCI Express 167e NetXtreme BCM5751F Fast Ethernet PCI Express 169d NetLink BCM5789 Gigabit Ethernet PCI Express 16dd NetLink BCM5781 Gigabit Ethernet PCI Express 16f7 NetXtreme BCM5753 Gigabit Ethernet PCI Express 16fd NetXtreme BCM5753M Gigabit Ethernet PCI Express 16fe NetXtreme BCM5753F Fast Ethernet PCI Express The Broadcom guys can speak-up, but I figure they know if "PCI Express" is appropriate for their device... :-)
Yes, "PCI Express" is appropriate. Thanks John.