Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
From: Christoph Lameter <hidden>
Date: 2005-05-18 02:53:01
Also in:
lkml
From: Christoph Lameter <hidden>
Date: 2005-05-18 02:53:01
Also in:
lkml
On Tue, 17 May 2005, Andrew Morton wrote:
Christoph Lameter [off-list ref] wrote:quoted
NUMA awareness for the e1000 driver. Allocate transmit and receive buffers on the node of the device.Hast thou any benchmarking results?
Yes, your honor. Just a second .... The patch has been around for a long time. No benchmarks results in my email archive. Would need to talk to some folks tomorrow and maybe we would have to run some new benchmarks.
quoted
- txdr->buffer_info = vmalloc(size); + txdr->buffer_info = kmalloc_node(size, GFP_KERNEL, node);How come that this is safe to do
Because physically contiguous memory is usually better than virtually contiguous memory? Any reason that physically contiguous memory will break the driver?