Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class

In article [ref] (at Thu, 05 May 2005 21:39:47 +1000), Herbert Xu [off-list ref] says:

YOSHIFUJI Hideaki / ???? [off-list ref] wrote:

quoted

In article [ref] (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie [off-list ref] says:

quoted

+struct iscsi_uevent {

:

quoted

+} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.

Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

Well, this if for avoiding inconsistency between kernel and userspace.
If you use unsigned long, sizeof(unsigned long) may be inconssitent
between kernel and userland like this:
  kernel:    sizeof(unsigned long) == 8
  userspace: sizeof(unsigned long) == 4

--yoshfuji