[PATCH 2/3] add open iscsi netlink interface to iscsi transport class

attached common-iscsi-headers.patch - Common header files:
  - iscsi_if.h (user/kernel #defines);
  - iscsi_proto.h (RFC3720 #defines and types);
  - iscsi_ifev.h (user/kernel events).


Thanks,

Linux-iscsi Team

Signed-off-by: Alex Aizman <redacted>
Signed-off-by: Dmitry Yusupov <redacted>
Signed-off-by: Mike Christie <redacted>

In article [off-list ref] (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie [off-list ref] says:

+struct iscsi_uevent {

:

+} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.
Please check other spots, too. e.g.:

+	struct iscsi_stats_custom custom[0]
+		__attribute__ ((aligned (sizeof(unsigned long))));

--yoshfuji

YOSHIFUJI Hideaki / ???? [off-list ref] wrote:

In article [off-list ref] (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie [off-list ref] says:

quoted

+struct iscsi_uevent {

:

quoted

+} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.

Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

In article [off-list ref] (at Thu, 05 May 2005 21:39:47 +1000), Herbert Xu [off-list ref] says:

YOSHIFUJI Hideaki / ???? [off-list ref] wrote:

quoted

In article [off-list ref] (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie [off-list ref] says:

quoted

+struct iscsi_uevent {

:

quoted

+} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.

Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

Well, this if for avoiding inconsistency between kernel and userspace.
If you use unsigned long, sizeof(unsigned long) may be inconssitent
between kernel and userland like this:
  kernel:    sizeof(unsigned long) == 8
  userspace: sizeof(unsigned long) == 4

--yoshfuji

On Thu, May 05, 2005 at 06:55:03PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:

In article [off-list ref] (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie [off-list ref] says:

quoted

+struct iscsi_uevent {

:

quoted

+} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.

Actually, it's completely unnecessary.  iscsi_uevent contains a uint64_t
element, and the GCC docs (in the 'Type attribute' section, documenting
aligned) say:

     Note that the alignment of any given `struct' or `union' type is
     required by the ISO C standard to be at least a perfect multiple of
     the lowest common multiple of the alignments of all of the members
     of the `struct' or `union' in question.  This means that you _can_

So best to just delete it.  It has no effect.

Please check other spots, too. e.g.:

quoted

+	struct iscsi_stats_custom custom[0]
+		__attribute__ ((aligned (sizeof(unsigned long))));

This one's probably useless too, but it's hard to tell since the patches
weren't sent inline thus making them difficult to cross-reference.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

On Thu, 2005-05-05 at 21:39 +1000, Herbert Xu wrote:

YOSHIFUJI Hideaki / ???? [off-list ref] wrote:

quoted

In article [off-list ref] (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie [off-list ref] says:

quoted

+struct iscsi_uevent {

:

quoted

+} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.

Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

why align at all as opposed to just letting the compiler figure it out.