Thread (26 messages) 26 messages, 4 authors, 2005-06-03

Re: PATCH: rtnetlink explicit flags setting

From: Thomas Graf <tgraf@suug.ch>
Date: 2005-05-28 01:28:10

* jamal [ref] 2005-05-27 21:12
quoted
Yet unconverted
are: netfilter, net/sched/ tcp_diag, xfrm, kernel/audit.
I didnt find any issues with these as far as PID extrapolation.
I should have written, yet unchecked.
quoted
I also fixed some uses of NL_CREDS() to fetch the pid for
message generation which is wrong. Various dumping procedures
did not set the multi flag at all, I fixed all of them.

Do not apply these patches yet, they're way too intrusive
Do you mean the two patches? Those looked fine to me;
Yes, those two patches. My part comes directly out of my fingers
and is only compile tested. I didn't even run them yet.
i.e its mostly the patch i posted this morning with the new Macros, no?
I went through all users of NLMSG_PUT in the modules you touched and
checked if they properly set NLM_F_MULTI and used the new macro when
appropriate.

Anyways, I want to be careful with this, there might be userspace
apps which rely on pid being filled in from siocb->scm->creds or
userspace apps which don't expect the NLM_F_MULTI flag even when
they should so we should check with all parties involved.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help