Thread (6 messages) 6 messages, 3 authors, 2005-05-26

Re: [PATCH] : bug fix in multipath drr code.

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-05-24 07:11:46

On Tue, May 24, 2005 at 12:16:38PM +0530, pravin b shelar wrote:
quoted
The multipath_comparekeys isn't necessary either.
In concurrent invocations of drr_select_route() last_selection will
change to different route.
So in that case we can not  use last_selection route on basis of
FLOWI_FLAG_MULTIPATHOLDROUTE flag only, since old
route might be totally different due another invocation of same function.
So, I think multipath_comparekeys is necessary.
Indeed.  In fact this whole MULTIPATHOLDROUTE thing can't possibly
work at all.  I'd suggest that it be removed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help