Thread (8 messages) 8 messages, 5 authors, 2005-05-25

Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (network) test on RHEL4 with kernel 2.6.12-rc1-mm4

From: Jeff Garzik <hidden>
Date: 2005-05-16 21:58:52

Herbert Xu wrote:
On Mon, May 16, 2005 at 10:43:02AM -0700, Ganesh Venkatesan wrote:
quoted
@@ -1708,11 +1778,15 @@ err_rx_clean_list:
static void e100_down(struct nic *nic)
{
+#ifdef CONFIG_E100_NAPI
+       /* wait here for poll to complete */
+       netif_poll_disable(nic->netdev);
+#endif

Sorry, you can't do that here since you're in softirq context and
netif_poll_disable may sleep.
I think the intention is that e100_down() may sleep, from looking at all 
the callsites.

Only e100_tx_timeout() calls it in a context that prevents sleep.

	Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help