Thread (17 messages) 17 messages, 8 authors, 2005-05-06

Re: netfilter6: ICMPv6 type 143 doesn't match

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-05-06 13:22:42
Also in: netfilter-devel

Patrick McHardy [off-list ref] wrote:
+static inline int mld_dev_queue_xmit2(struct sk_buff *skb)
+{
+       struct net_device *dev = skb->dev;
+
+       if (dev->hard_header) {
+               unsigned char ha[MAX_ADDR_LEN];
+               int err;
+
+               ndisc_mc_map(&skb->nh.ipv6h->daddr, ha, dev, 1);
+               err = dev->hard_header(skb, dev, ETH_P_IPV6, ha, NULL, skb->len);
+               if (err < 0) {
+                       IP6_INC_STATS(IPSTATS_MIB_OUTDISCARDS);
You're now incrementing this twice since the callers will also
increment this.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help