Thread (29 messages) 29 messages, 4 authors, 2005-05-05

Re: patch: Action repeat

From: Thomas Graf <tgraf@suug.ch>
Date: 2005-05-04 12:31:57

* jamal [ref] 2005-05-04 07:46
Basically, something along those lines (eg struct tca_pkt_info) in which
the tcf_result is one of the components should do it. 

I would be satisfied with this being the structure in the ->act()
parameters because then it could also be used to pass action-metadata
around (no action written so far needs such coordination, but its been
one of those things i have been thinking of for some dynamic creations
for example  where the return code is insufficient to describe things).
Patrick, either you or i could do it. It doesnt matter if at the moment
the structure only contains tcf_result or elements of tcf_result because
i will add more to it later. Then we could kill access to tc_classid in
exec()
Sounds good.
Global I believe means you dont reset it when you clone/copy.
skb->tc_verd is only cleared when we free the skb at the moment and
transfered when we clone or copy. A bit or two could be reserved in the
tc_verd to say "clear tc_classid" and have the meta action decide if it
is global(dont clear) or not(clear - current behavior) during
clone/copy . Does this sound reasonable?
I have no objections but fail to see why we want to clear it anyway?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help