Thread (34 messages) 34 messages, 8 authors, 2005-04-02

Re: RFC: Redirect-Device

From: Stephen Hemminger <hidden>
Date: 2005-03-31 21:05:12

You need to cleanup the style.  
	Lots of dead commented out code.
	Encapsulating locking in macros is ugly and makes maintenance a nuisance.
       CamelCaps
        Use prdebug instead of DEBUG
	RCU instead of rwlock's or just use spinlock
	Adding new /proc interfaces is frowned on
	Adding new ioctl's are very frowned on
	global namespace issues with toupper et a..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help