On Mon, 28 Mar 2005, Thomas Graf wrote:

Looks good, except...

quoted

+				err = -EAGAIN;

You're missing a goto err_out here, the ops == NULL won't catch it.

quoted

+			}
 		}
 	}
 #endif

-	err = -EINVAL;
 	if (ops == NULL)
 		goto err_out;

With the above goto inserted there is no need to move the err = -EINVAL.

Thanks, Thomas.

You are right.

I'm redoind the patch right now.

---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/