Re: [PATCH: 2.6.12-rc1] mii: Add test for GigE support
From: Jeff Garzik <hidden>
Date: 2005-03-22 23:27:47
Dale Farnsworth wrote:
quoted hunk ↗ jump to hunk
This patch adds the ability to test a PHY for GigE support Signed-off-by: Dale Farnsworth <redacted> Index: linux-2.5-enet/drivers/net/mii.c ===================================================================--- linux-2.5-enet.orig/drivers/net/mii.c +++ linux-2.5-enet/drivers/net/mii.c@@ -207,6 +207,21 @@ return 0; } +int mii_check_gmii_support(struct mii_if_info *mii) +{ + int reg; + + reg = mii->mdio_read(mii->dev, mii->phy_id, MII_BMSR); + if (reg & BMSR_HAS_EXTSTAT1000) { + reg = mii->mdio_read(mii->dev, mii->phy_id, MII_EXTSTAT1000); + if (reg & (ESR_1000_BASE_X_FD | ESR_1000_BASE_T_FD | + ESR_1000_BASE_X_HD | ESR_1000_BASE_T_HD)) + return 1; + } + + return 0;
Two comments: 1) you need to add EXPORT_SYMBOL() when adding new API functions (see the bottom of the file). 2) Reading a non-existent register will return all 1's in most cases, so I am not sure if this is the best test. Jeff