Re: netif_rx packet dumping
From: Thomas Graf <tgraf@suug.ch>
Date: 2005-03-08 18:37:59
* Andi Kleen [ref] 2005-03-08 19:18
There are some other savings possible e.g. from a quick look: - skb->list is afaik totally unnecessary and probably even unused. - struct timeval could be an optimized structure using 32bit for the sub second part. (would need moving it somewhere else, otherwise alignment doesn't help) - Are really three device pointers needed? Perhaps things can be a bit optimized here.
Likely that real_dev can be moved to cb. I would like to keep indev though, it really helps at policy routing decisions.
- Hippi could be finally changed to use skb->cb instead of its private field.
Definitely.
- is skb->security still needed? It should be obsolete with ->sec_path, no? Would only help together with the timestamp optimization.
security has been unused for quite some time as far as I can see. Anyone going for a patch? Otherwise I'll give it a try. Speaking of it, I see tcp_sock is marginal over 2**10 on 32 bit archs and Stephen's plans to outsource the cc bits brings us closer to the border. Would it be worth to try and get it below 2**10? I spotted some places for optimizations but not enough to really save the needed amount.