Re: [PATCH 2/2] r8169: RTL8169_registers clean-up
From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2005-02-28 19:59:58
From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2005-02-28 19:59:58
Jon Mason [off-list ref] :
An attempt to clean-up RTL8169_registers and RTL8169_register_content. Adjusted tab alignment and converted decimal values to hex. Applies cleanly to linux-2.6.11-rc4-mm1 and tested on amd64
1 - It does not use bitwise shifts where possible (suggested by Jeff);
2 - It is not consistent (see TxDesc...);
3 - Please write a script to reduce the patch and prove that a typo does
not hide somewhere (yep, I'm lazy). It would take too much testing
to get a complete coverage.
Jeff, how am I supposed to handle cleanups now ? Just say no ? :o)
--
Ueimor