Re: [RFC] meta ematch

* jamal [ref] 2005-01-16 12:18

On Sun, 2005-01-16 at 11:32, Thomas Graf wrote:

quoted

Not really as long as iproute2 uses the same byte ordering. It has the
same issues as all other rtnetlink users.

wont harm to do a quick test if you have hardware. pedit for example 
still has some occasional issues some issues with big endian which i
havent had time to chase.

Uhmm.. yes. The endianess comes in at sutff like skb->protocol. Leaving
it to userspace makes comparison beyond simple equals quite difficult.
Providing a method to transform in kernel space adds more complexity.

quoted

quoted

quoted

+	return (v + (FIXED_1/200)) >> FSHIFT;

200 has some magic connotation to it - a define somewhere perhaps?

I coped this from the code for procfs ;->

know why they have that number? It must have some significance - or
maybe someone just stuck their hand in the air and measured 200? ;->

It is some kind of factor and has almost no impact in our case because
it only changes the first 4 bits in the exp part and I'm only interested
in the integer part. It might be a good idea to take a few bits in from
the exp part and provide the load as *10^n where n is either 2 or 3,
i.e. a load of 1.9 would be 190. I have to think a little more about
this.