Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state
From: Dave Dillow <dave@thedillows.org>
Date: 2004-12-30 16:16:57
Also in:
lkml
From: Dave Dillow <dave@thedillows.org>
Date: 2004-12-30 16:16:57
Also in:
lkml
On Thu, 2004-12-30 at 04:48, Jan-Benedict Glaw wrote:
On Thu, 2004-12-30 03:48:34 -0500, David Dillow [off-list ref] wrote in message [ref]:quoted
diff -Nru a/include/net/xfrm.h b/include/net/xfrm.h--- a/include/net/xfrm.h 2004-12-30 01:12:08 -05:00 +++ b/include/net/xfrm.h 2004-12-30 01:12:08 -05:00@@ -146,6 +146,9 @@ /* Private data of this transformer, format is opaque, * interpreted by xfrm_type methods. */ void *data; + + /* Intended direction of this state, used for offloading */ + int dir; }; enum {@@ -157,6 +160,12 @@ XFRM_STATE_DEAD }; +enum { + XFRM_STATE_DIR_UNKNOWN, + XFRM_STATE_DIR_IN, + XFRM_STATE_DIR_OUT, +};Any specific reason to first define such a nice enum and then using int in the struct?
Just following the current style in net/xfrm.h, see xfrm_state.km.state and XFRM_STATE_*. Though, I probably should have used a u8; easily changed if it is an issue. -- Dave Dillow [off-list ref]