Re: [PATCH][BRIDGE-NF] Fix wrong use of skb->protocol
From: Lennert Buytenhek <hidden>
Date: 2004-12-30 22:24:15
From: Lennert Buytenhek <hidden>
Date: 2004-12-30 22:24:15
On Thu, Dec 30, 2004 at 07:55:14PM +0100, Bart De Schuymer wrote:
ip_sabotage_out() needs to distinguish IPv4 and IPv6 traffic. It currently does that by looking at skb->protocol. However, for locally originated packets, skb->protocol is not initialized. The patch below instead looks at the version number of the packet's data, which should be 4 or 6.
A while ago there were a number of problems with bridging CIPE ethernet devices, which turned out to be the bridge code not initialising skb->protocol for locally originated STP frames. At the time I was told that initialising skb->protocol for locally originated packets is required, so that is how I fixed it then. cheers, Lennert