Thread (11 messages) 11 messages, 4 authors, 2004-12-31

Re: [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes

From: Arnaldo Carvalho de Melo <hidden>
Date: 2004-12-30 22:12:04

Patrick McHardy wrote:
jamal wrote:
quoted
Patrick,
Thanks for this cleanup.

Questions/comments:

1)compiler or style issue?

You have a few of fixes from

a)
 if (..){
    single statement here;
}
 
to:
if (..)
    single statement here;

I always add an extra pair of brace
for lazy reasons (in the back of my mind: incase i want to add another
statement ;->).

Just cleanup, I prefer not to waste too many lines. Saving
space increases readability.
Agreed, whenever I have the chance, I remove such bloat ;)

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help