Re: [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action
From: jamal <hidden>
Date: 2004-12-30 13:17:14
From: jamal <hidden>
Date: 2004-12-30 13:17:14
On Wed, 2004-12-29 at 22:41, Patrick McHardy wrote:
Disable broken override bits in pedit action. It misses locking and needs to allocate new memory if nkeys increases. Also disable it for now.
There are a couple of these that you have (ipt being other). Could you just add a check for size before returning -EOPNOTSUPP? Example: if (ovr) if (p->nkeys != parm->nkeys) return -EOPNOTSUPP; This way if they are of the same size then things should work as is and my testcases dont break. Now if you feel more gracious, go ahead and fix them ;->
ret = -EEXIST;
if (ovr) {
+ /* FIXME: no locking, larger memory area might be required */
+ return -EOPNOTSUPP;
ret = 0;
override:
p->flags = parm->flags;cheers, jamal