Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET

On Thu, 18 Nov 2004, Alan Cox wrote:

On Iau, 2004-11-18 at 08:27, James Morris wrote:

quoted

2) Ensure that unix_dgram_sendmsg() fails for SOCK_SEQPACKET sockets which
are not connected, otherwise someone could bypass LSM by sending on an
unconnected socket.

What about half closed and other connected states ? This patch seems
inadequate for things like X.25

The patch only affects the Unix code and does not change existing 
semantics for other connected states.

One thing that looks broken (unrelated to the patch I posted) is that
unix_dgram_sendmsg() already does not check sk->sk_shutdown &
SEND_SHUTDOWN for SOCK_SEQPACKET.


- James
-- 
James Morris
[off-list ref]