Re: net/ne2k-pci: module_param conversion

From
Domen Puncer <hidden>
Date
2004-11-24 20:43:48
Reply to
Jeff Garzik, 2004-11-24
On 24/11/04 15:05 -0500, Jeff Garzik wrote:
janitor@sternwelten.at wrote:
quoted
@@ -443,8 +435,7 @@ static void ne2k_pci_reset_8390(struct n
{
	unsigned long reset_start_time = jiffies;

-	if (debug > 1) printk("%s: Resetting the 8390 t=%ld...",
-						  dev->name, jiffies);
+	printk(KERN_INFO "%s: Resetting the 8390 t=%ld...", dev->name, 
jiffies);

The rest of the patch looks OK.

This chunk changes behavior, by removing the 'if' test.
This was intended.
Module parameter debug is only used in this test, so i dared removing it.
3 options:
- remove this printk
- don't remove "debug"
- leave patch as is :-)

Let me know of your decision, and i'll send a new patch.
	Jeff
Thread (3 messages) 3 messages, 3 authors, last reply 2004-11-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help