Thread (2 messages) 2 messages, 2 authors, 2004-10-30

Re: net: generic netdev_ioaddr

From: Al Viro <hidden>
Date: 2004-10-30 01:43:14
Also in: lkml

Possibly related (same subject, not in this thread)

On Fri, Oct 29, 2004 at 09:18:18PM +0200, Krzysztof Halasa wrote:
"Pekka J Enberg" [off-list ref] writes:
quoted
Yup, I thought about that after I sent the patch. However, as it
stands now, many network drivers use netdev->base_addr for just that.
Perhaps it should be nuked completely instead?
I thinks so. With ifmap, SIOCSIFMAP, ifr_map, mem_end etc.,
irq, if_port, dma.
SIOCSIFMAP is unfortunate, but legitimate - it passes more or less
opaque structure to driver and lets driver interpret it.

SIOCGIFMAP, OTOH, is really bad - among other things, for many drivers
it leaks ioremapped addresses to userland.  And *that* is a LARTable
offense - it's an information that makes no sense whatsoever for userland
code and should never be exposed, just as with any kernel pointers.

What uses ->base_addr from the data returned by SIOCGIFMAP?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help