Re: [PATCH] Make netif_rx_ni preempt-safe

On Thu, 21 Oct 2004 10:35:03 +1000
Herbert Xu [off-list ref] wrote:

On Wed, Oct 20, 2004 at 05:15:08PM -0700, David S. Miller wrote:

quoted

 
+int netif_rx_ni(struct sk_buff *skb)
+{
+       int err = netif_rx(skb);
+
+       preempt_disable();
+       if (softirq_pending(smp_processor_id()))
+               do_softirq();

You need to move the netif_rx call inside the disable as otherwise
you might be checking the pending flag on the wrong CPU.

Good catch, I've made that fix in my tree.

Thanks.