Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2004-10-30 01:51:01
Matt Domsch [off-list ref] wrote:
s/dev_addr/addr_len in the comments above, that's the field we care about being non-zero.
This still doesn't make sense. What if dev->addr_len is less than the size of the buffer? The caller has to know what the length is anyway. BTW, the ioctl interface is obsolete. Please use the rtnetlink interface where dev->addr_len can be read properly. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt