On Mon, Sep 27, 2004 at 04:04:54PM -0700, David S. Miller wrote:

quoted

IMHO we should still fix it though at least for consistency.

That early on in the connection, it should be setting both
values, right?  If so your patch still needs a tweak. :)

I'm not saying that this patch makes any difference in terms of
run-time results.  At that point both mss_cache and mss_cache_std
should contain the same values.

However, since the value that's intended here is the physical MSS,
we should use mss_cache_std for the sake of consistency.

The only reason I spotted this at all is because I grepped -w for
mss_cache and found this function as one of the very few users.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt